Correction to android setup for RN > 60 #1889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rinku-k , Thanks for contributing! We will investigate it soon. |
andreidubov
reviewed
Oct 19, 2020
rinku-k
commented
Oct 20, 2020
andreidubov
reviewed
Oct 20, 2020
| @@ -22,16 +22,18 @@ In order to integrate CodePush into your Android project, please perform the fol | |||
| 1. In your `android/settings.gradle` file, make the following additions: | |||
|
|
|||
| ```gradle | |||
| include ':app', ':react-native-code-push' | |||
| include ':app', ':react-native-code-push'. // Append ':react-native-code-push' to :app | |||
There was a problem hiding this comment.
Yes I agree with this addition, now it gives more clarity.
andreidubov
reviewed
Oct 20, 2020
| project(':react-native-code-push').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-code-push/android/app') | ||
| ``` | ||
|
|
||
| 2. In your `android/app/build.gradle` file, add the `codepush.gradle` file as an additional build task definition underneath `react.gradle`: | ||
| 2. In your `android/app/build.gradle` file, add the `codepush.gradle` file as an additional build task definition underneath `react.gradle` or `native_modules.gradle`(in case of RN [build issue](https://github.com/facebook/react-native/issues/25631)): |
There was a problem hiding this comment.
Thank you for your contribution, but in fact, I think that this does not apply to setting up CodePush, but is related to setting up the react-native app, and should not appear in our documentation. In my opinion, we should remove this so as not to confuse people who do not use native_modules.gradle. Could update this PR and remove this change. If you have a different opinion, let me know and we will discuss it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction to android setup for RN > 60 causing bundling issue
#1872