Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plugin containers and code removal #449

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

ms-lolo
Copy link
Collaborator

@ms-lolo ms-lolo commented Jan 27, 2025

renaming the apps.PluginContainers class to apps.PythonEntryPointContainer for clarity since we have a few other things called plugins already. also using this pr to delete as much code outside of rats-apps as possible. leaving the components in place but will be deleting the src/test contents and removing the components from being built and released. we think these are possible future components but want to clear the way to release rats-apps and rats packages without broken dependencies.

Lorenzo Pisani added 2 commits January 27, 2025 09:47
we have too many things called plugins so we're making this one much
more specific to clarify that this is about the entry points defined in
pyproject.toml
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.71%. Comparing base (9ece7bc) to head (10a0b67).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (9ece7bc) and HEAD (10a0b67). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ece7bc) HEAD (10a0b67)
5 4
Additional details and impacted files
Components Coverage Δ
rats-apps ∅ <ø> (∅)
rats-devtools ∅ <ø> (∅)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ms-lolo ms-lolo merged commit d25c9a6 into main Jan 27, 2025
19 checks passed
@ms-lolo ms-lolo deleted the feature/plugin-containers-and-code-removal branch January 27, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant