Feature/devtools experiment #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results: oneml-pipelines31 tests 31 ✅ 0s ⏱️ Results for commit 578cdef. ♻️ This comment has been updated with latest results. |
Test Results: oneml-processors112 tests 112 ✅ 4s ⏱️ Results for commit 578cdef. ♻️ This comment has been updated with latest results. |
ms-lolo
commented
Jan 12, 2024
ms-lolo
commented
Jan 12, 2024
ms-lolo
commented
Jan 12, 2024
- remove dependency to immunodata - add click library for experimentation - install oneml-pipelines so we can use services - add setuptools because pycharm needs it - register a oneml-devtools script with poetry
this method complicates the api quite a bit but i've never used it so i would rather think about adding something when a use case comes up.
this allows this wheel to be installed on already-published versions of oneml-pipelines. when this package is installed with pipx, it has to download the dependencies from our ado registry.
this allows us to build some dev experience commands that we can share across components.
ms-lolo
force-pushed
the
feature/devtools-experiment
branch
from
61111a9 to
7d8de28
Compare
…ls-experiment # Conflicts: # .azure-pipelines/ci/core.yaml # .azure-pipelines/ci/pr.yaml # .azure-pipelines/templates/jobs.application-ci.check-all.yaml # .azure-pipelines/templates/jobs.application-ci.docker.yaml # .azure-pipelines/templates/jobs.application-ci.wheel.yaml # .azure-pipelines/templates/jobs.deploy-app.yaml # .azure-pipelines/templates/jobs.deploy-jupyter-kernel.core.yaml # .azure-pipelines/templates/jobs.docs.yaml # .azure-pipelines/templates/jobs.list-experiment-configs.yaml # .azure-pipelines/templates/jobs.list-experiments.yaml # .github/workflows/ci.yaml # oneml-habitats/poetry.lock # oneml-habitats/pyproject.toml
ms-lolo
commented
Feb 2, 2024
ms-lolo
commented
Feb 2, 2024
ms-lolo
commented
Feb 2, 2024
ms-lolo
commented
Feb 2, 2024
elonp
reviewed
Feb 2, 2024
ms-lolo
commented
Feb 2, 2024
ms-lolo
commented
Feb 2, 2024
|
change cg pipeline to fail on warnings |
looks like poetry is being supported now (beta) natively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immunomics R&D Infrasub for better isolationsome reasoning:
before this pr, we used the devtools component to install development packages into all our actual components. but this caused complexity with lots of unnecessary dependencies and made the packaging and releasing of the products difficult because of a "special" local dependency.
the new structure inverts the dependency so nothing depends on
devtools, leaving the released product in a cleaner state without anything special about them. we use the new devtools component to create commands meant to help us keep this repo in a healthy state. for example,oneml-devtools generate-cg-manifest [path]generates acgmanifest.jsonfile in the component pointed to by thepathargument. since this logic is not something we want to release as part of oneml packages, putting it indevtoolsmeans the other components have no relationship to it. i think of the devtools component as a place to put maintenance logic that is more complex than what we could do in small bash scripts.