Add support for detecting $VIRTUAL_ENV
#181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
PR Overview
This pull request adds support for detecting and including the “VIRTUAL_ENV” environment variable path when listing global virtual environment directories.
- Introduces a new parameter (virtual_env_env_var) to the list_global_virtual_envs_paths function.
- Checks and appends the detected path for “VIRTUAL_ENV” if it exists.
- Calls the updated function in find.rs to pass environment.get_env_var("VIRTUAL_ENV").
Changes
| File | Description |
|---|---|
| crates/pet-global-virtualenvs/src/lib.rs | Adds a new optional parameter to handle the “VIRTUAL_ENV” variable |
| crates/pet/src/find.rs | Passes the “VIRTUAL_ENV” environment variable to the updated function |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
| @@ -56,11 +56,20 @@ fn get_global_virtualenv_dirs( | |||
| } | |||
|
|
|||
| pub fn list_global_virtual_envs_paths( | |||
| virtual_env_env_var: Option<String>, | |||
There was a problem hiding this comment.
Consider adding a documentation comment explaining how this new parameter is used for capturing $VIRTUAL_ENV. This helps future maintainers understand its purpose.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #180
(this is me writing rust for the first time 😬)