Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public methods for Load(Stream...) and LoadAsync(Stream,...), inc… #207

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rysweet
Copy link

@rysweet rysweet commented Mar 13, 2025

This PR adds public methods for Load(Stream...) and LoadAsync(Stream,...) and tests for each.

This enables you to include prompty files as an embedded resource in the dll and reference them as a Stream.

This closes #206

@rysweet
Copy link
Author

rysweet commented Mar 13, 2025

I wasn't sure where to add doc, if any

@rysweet rysweet mentioned this pull request Mar 13, 2025
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the warnings flagged LGTM

@rysweet
Copy link
Author

rysweet commented Mar 13, 2025

Aside from the warnings flagged LGTM

I'm not seeing warnings - happy to track them down just not sure where you are seeing them ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: .NET - support Load(Stream, ...)
2 participants