Users/daviwu/update branch csharp #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the C# branch by introducing Mustache support and unit tests while refactoring model properties and template handling for improved consistency. Key changes include the addition of a new Property model, updates to unit tests to verify renderer and parser functionality, and refactoring of the Template and Prompty classes to use more descriptive naming and proper configurations.
Reviewed Changes
| File | Description |
|---|---|
| runtime/promptycs/Prompty.Core/Model/Property.cs | New model classes and property conversion logic supporting various property types |
| runtime/promptycs/Prompty.Core.Tests/RenderererTests.cs | Tests for synchronous and asynchronous renderers with updated inline data |
| runtime/promptycs/Prompty.Core.Tests/ParserTests.cs | Additional tests for the new parser method with argument parsing |
| runtime/promptycs/Prompty.Core.Tests/LoadTests.cs | New tests for sample parameters and merged sample preparation with updated method parameters |
| runtime/promptycs/Prompty.Core/Model/Template.cs | Renaming of the Type property to Format and addition of a Strict flag |
| runtime/promptycs/Prompty.Core/Normalizer.cs | Update to ProcessFile to use the directory name and throw an exception for missing files |
| runtime/promptycs/Prompty.Core/InvokerFactory.cs | Update to use the Format property when creating renderer instances |
| runtime/promptycs/Prompty.Core.Tests/PrepareTests.cs | Updated prepare calls to include the mergeSample parameter |
| runtime/promptycs/Prompty.Core/Model/Prompty.cs | Changed Inputs and Outputs from arrays to dictionaries for clarity in property mapping |
Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.
Update as Copilot suggests Co-authored-by: Copilot <[email protected]>
Update as Copilot suggests Co-authored-by: Copilot <[email protected]>
Update as Copilot suggests Co-authored-by: Copilot <[email protected]>
Update as Copilot suggests Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is from branch
csharp, the 2nd commit adds Mustache support and unit tests