Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new prompty unit test for Mustache #199

Conversation

YusakuNo1
Copy link
Member

No description provided.

@YusakuNo1 YusakuNo1 requested a review from Copilot March 1, 2025 09:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds a new prompt to the unit tests for Mustache processing in the prompty project.

  • Expanded test coverage by including "prompts/basic_mustache.prompty" in the test factory invoker.
  • Ensures that Mustache-based prompt functionality is validated via unit tests.

Reviewed Changes

File Description
runtime/prompty/tests/test_factory_invoker.py Added "prompts/basic_mustache.prompty" to test configuration

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Member Author

@YusakuNo1 YusakuNo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments left from Copilot

@YusakuNo1 YusakuNo1 self-assigned this Mar 4, 2025
@YusakuNo1 YusakuNo1 requested a review from Copilot March 4, 2025 06:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds a new unit test case for Mustache functionality by including an additional prompt file in the test configuration.

  • Added a new prompt file "prompts/basic_mustache.prompty" in the factory invoker test configuration.
  • Ensures the Mustache prompt changes are exercised in unit tests.

Reviewed Changes

File Description
runtime/prompty/tests/test_factory_invoker.py Added the new "prompts/basic_mustache.prompty" to the list of prompt files to support Mustache unit tests.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@YusakuNo1 YusakuNo1 merged commit 9ec6047 into microsoft:main Mar 4, 2025
16 checks passed
@YusakuNo1 YusakuNo1 deleted the users/daviwu/pyton-add-mustache-unit-test branch March 4, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant