-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky unselect test #33060
Conversation
test('should select with multiple attribute', async ({ openRecorder }) => { | ||
const { page, recorder } = await openRecorder(); | ||
|
||
await recorder.setContentAndWait(`<select id="age" multiple onchange="console.log('[' + [...age.selectedOptions].map(x => x.value).join(',') + ']')"><option value="1">1</option><option value="2">2</option></select>`); | ||
|
||
const locator = await recorder.hoverOverElement('select'); | ||
expect(locator).toBe(`locator('#age')`); | ||
await clickMultipleSelectOption(page.getByRole('option', { name: '1' })); | ||
await page.locator('select').focus(); | ||
await page.selectOption('select', ['1']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: if you don't focus, it throws here that activeModel
is null.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -464,3 +464,41 @@ it('should click in custom element', async ({ page }) => { | |||
await page.locator('input').click(); | |||
expect(await page.evaluate('window.__clicked')).toBe(true); | |||
}); | |||
|
|||
for (const mode of ['same-context', 'different-context'] as const) { | |||
it(`concurrent selectOption in ${mode} should work`, async ({ browser, browserName, isLinux }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test results for "tests others"5 flaky20557 passed, 495 skipped Merge workflow run. |
Test results for "tests 1"2 failed 5 flaky35878 passed, 624 skipped Merge workflow run. |
Test results for "tests 2"49 failed 81 flaky238945 passed, 9481 skipped Merge workflow run. |
This is flaky since it was added in #32127.
Follow-up to #32127 (comment).
Added an isolated test for the WebKit/Linux bug in #33064.