Reapply "fix(har timing): record connect timing for proxied connections" (#32855) #33003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions" (microsoft#32989) This reverts commit 1b589c4.
Test results for "tests others"20556 passed, 491 skipped Merge workflow run. |
Test results for "tests 1"1 flaky35860 passed, 619 skipped Merge workflow run. |
mxschmitt
reviewed
Oct 8, 2024
| @@ -515,11 +514,21 @@ export abstract class APIRequestContext extends SdkObject { | |||
| }), | |||
| ); | |||
|
|
|||
| // when using socks proxy, having the socket means the connection got established | |||
| if (agent instanceof SocksProxyAgent) | |||
There was a problem hiding this comment.
this should be also the case for HttpsProxyAgent? So maybe we should check for just agent thruthyness there?
There was a problem hiding this comment.
HTTPSProxyAgent emits its own separate event that's more precise, so we use that: https://github.com/microsoft/playwright/pull/33003/files#diff-dc06386362e7da98cd82627a6b4f337ae01799a53cac4f208089b2b89c4dc832R527-R529
Test results for "tests 2"2 fatal errors, not part of any test 56 flaky238809 passed, 9422 skipped, 13 did not run Merge workflow run. |
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 29, 2025
…onnections" (microsoft#32855) (microsoft#33003)" This reverts commit 042161e.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 29, 2025
…d connect timing for proxied connections" (microsoft#32855) (microsoft#33003)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies what we reverted in #32989.
Max and me debugged this, and found that the test failures come from SOCKS proxy now preferring IPv6 over IPv4. We've updated the tests and made sure that this doesn't mask any breaking change.
I'm enabling CQ1 to make sure we don't oversee any other CI failures.