Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webkit): 204 response is not a failure #32768

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Sep 23, 2024

The login being changed was added in #1260 and is supposed to only work for navigation requests.

Reference: #32752

Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [playwright-test] › playwright.ct-dev-server.spec.ts:21:5 › should run dev-server and use it for tests
❌ [installation tests] › playwright-packages-install-behavior.spec.ts:66:5 › playwright should work
❌ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-2.spec.ts:408:7 › cli codegen › click should emit events in order

5 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:256:1 › should have network requests
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [chromium] › components/splitView.spec.tsx:35:5 › should render sidebar first
⚠️ [webkit-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [webkit-page] › page/page-goto.spec.ts:312:3 › should fail when navigating to bad SSL after redirects

36321 passed, 747 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit c9a26e6 into microsoft:main Sep 23, 2024
27 of 30 checks passed
@yury-s yury-s deleted the 204-resp-error branch September 23, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants