fix(trace-viewer): fix ui issue on network request details #32553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes can not show full body in network request details when response have multiple line, and fixes the scrollbar display issue in request details. Fixes microsoft#32552
This comment has been minimized.
This comment has been minimized.
mxschmitt
reviewed
Sep 12, 2024
| user-select: text; | ||
| line-height: 24px; | ||
| margin-left: 10px; | ||
| padding-left: 10px; |
There was a problem hiding this comment.
Suggested change
| padding-left: 10px; | |
| margin-left: 10px; |
There was a problem hiding this comment.
I reverted this for now. While it seems like an issue (double spacing) its unrelated to the actual issue we are fixing here. Happy to see a follow-up there.
Signed-off-by: Max Schmitt <[email protected]>
mxschmitt
added a commit
that referenced
this pull request
Sep 12, 2024
Test results for "tests 1"2 failed 1 flaky31611 passed, 584 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32552