Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(offline): implement offline in firefox #1476

Merged
merged 1 commit into from
Mar 22, 2020
Merged

feat(offline): implement offline in firefox #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"main": "index.js",
"playwright": {
"chromium_revision": "751710",
"firefox_revision": "1048",
"firefox_revision": "1049",
"webkit_revision": "1182"
},
"scripts": {
Expand Down
7 changes: 3 additions & 4 deletions src/firefox/ffBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ export class FFBrowserContext extends BrowserContextBase {
await this.grantPermissions(this._options.permissions);
if (this._options.extraHTTPHeaders || this._options.locale)
await this.setExtraHTTPHeaders(this._options.extraHTTPHeaders || {});
if (this._options.offline)
await this.setOffline(this._options.offline);
if (this._options.httpCredentials)
await this.setHTTPCredentials(this._options.httpCredentials);
if (this._options.geolocation)
await this.setGeolocation(this._options.geolocation);
if (this._options.offline)
await this.setOffline(this._options.offline);
}

_ffPages(): FFPage[] {
Expand Down Expand Up @@ -264,9 +264,8 @@ export class FFBrowserContext extends BrowserContextBase {
}

async setOffline(offline: boolean): Promise<void> {
if (offline)
throw new Error('Offline mode is not implemented in Firefox');
this._options.offline = offline;
await this._browser._connection.send('Browser.setOnlineOverride', { browserContextId: this._browserContextId || undefined, override: offline ? 'offline' : 'online' });
}

async setHTTPCredentials(httpCredentials: types.Credentials | null): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion test/browsercontext.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FF
});
});

describe.fail(FFOX)('BrowserContext.setOffline', function() {
describe('BrowserContext.setOffline', function() {
it('should work with initial option', async({browser, server}) => {
const context = await browser.newContext({offline: true});
const page = await context.newPage();
Expand Down