feat: support PLAYWRIGHT_GLOBAL_INSTALL=1 env variable
#1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can install playwright with ``` PLAYWRIGHT_GLOBAL_INSTALL=1 npm i playwright ``` to make it use a single shared location for all browser downloads. Fixes microsoft#1102
dgozman
approved these changes
Mar 22, 2020
download-browser.js
Outdated
| async function downloadBrowserWithProgressBar(downloadPath, browser, version = '') { | ||
| async function downloadBrowserWithProgressBar(downloadPath, browser, respectGlobalInstall = false) { | ||
| const PLAYWRIGHT_GLOBAL_INSTALL = respectGlobalInstall ? getFromENV('PLAYWRIGHT_GLOBAL_INSTALL') : false; | ||
| if (!!PLAYWRIGHT_GLOBAL_INSTALL && PLAYWRIGHT_GLOBAL_INSTALL.toLowerCase().trim() !== 'false') |
There was a problem hiding this comment.
nit: maybe respect 0 similar to false?
download-browser.js
Outdated
| const browserFetcher = require('./lib/server/browserFetcher.js'); | ||
| const packageJSON = require('./package.json'); | ||
| const envPaths = require('env-paths'); | ||
| const appPaths = envPaths('playwright'); |
There was a problem hiding this comment.
nit: I'd inline to the callsite.
awibox
approved these changes
Mar 23, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Mar 24, 2020
…rosoft#1470)" In an offline discussion, we ended up not liking the way it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can install playwright with
to make it use a single shared location for all browser
downloads.
Fixes #1102