New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo): implement geo override in ff #1438

Merged

pavelfeldman merged 1 commit into microsoft:master from pavelfeldman:fe_geo

Mar 21, 2020

Member

pavelfeldman commented Mar 20, 2020

No description provided.

dgozman reviewed

View reviewed changes

src/firefox/ffPage.ts

                   try {
                     await Promise.all([
                       // TODO: we should get rid of this call to resolve before any early events arrive, e.g. dialogs.
                       this._session.send('Page.addScriptToEvaluateOnNewDocument', {
                         script: '',
                         worldName: UTILITY_WORLD_NAME,
                       }),
+                      geolocation ? this._setGeolocation(geolocation) : Promise.resolve(),

Contributor

dgozman Mar 20, 2020

This makes popups not have geolocation override at the start. We should push to the browser context instead.


          feat(geo): implement geo override in ff

17b1861

pavelfeldman force-pushed the fe_geo branch from 813b9c9 to 17b1861 Compare

March 21, 2020 02:04

pavelfeldman merged commit c539325 into microsoft:master

pavelfeldman deleted the fe_geo branch

April 17, 2020 21:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet