Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark as flaky according to the new policy #1322

Merged
merged 1 commit into from
Mar 10, 2020
Merged

test: mark as flaky according to the new policy #1322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/browsercontext.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const utils = require('./utils');
/**
* @type {BrowserTestSuite}
*/
module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT}) {
module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FFOX, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
Expand Down Expand Up @@ -420,8 +420,8 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, FF
expect(response.status()).toBe(200);
await context.close();
});
// flaky: https://github.com/microsoft/playwright/issues/1303
it.fail(FFOX)('should fail if wrong credentials', async({browser, server}) => {
// flaky: https://github.com/microsoft/playwright/pull/1301/checks?check_run_id=496478707
it.fail(FFOX && LINUX)('should fail if wrong credentials', async({browser, server}) => {
server.setAuth('/empty.html', 'user', 'pass');
const context = await browser.newContext({
httpCredentials: { username: 'foo', password: 'bar' }
Expand Down
6 changes: 3 additions & 3 deletions test/evaluation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const bigint = typeof BigInt !== 'undefined';
/**
* @type {PageTestSuite}
*/
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) {
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
Expand Down Expand Up @@ -230,8 +230,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
await page.evaluate(e => e.textContent, element).catch(e => error = e);
expect(error.message).toContain('JSHandle is disposed');
});
it.fail(FFOX)('should simulate a user gesture', async({page, server}) => {
// Flaky on Limux: https://github.com/microsoft/playwright/issues/1305
// flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496501774
it.fail(FFOX && LINUX)('should simulate a user gesture', async({page, server}) => {
const result = await page.evaluate(() => {
document.body.appendChild(document.createTextNode('test'));
document.execCommand('selectAll');
Expand Down
10 changes: 5 additions & 5 deletions test/workers.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ const { waitEvent } = utils;
/**
* @type {PageTestSuite}
*/
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) {
module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, LINUX}) {
const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;

describe('Workers', function() {
// Flaky: https://github.com/microsoft/playwright/issues/1300
it.fail(FFOX)('Page.workers', async function({page, server}) {
// flaky: https://github.com/microsoft/playwright/pull/1297/checks?check_run_id=496348690
it.fail(FFOX && LINUX)('Page.workers', async function({page, server}) {
await Promise.all([
page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html')]);
Expand Down Expand Up @@ -102,8 +102,8 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
expect(destroyed).toBe(true);
expect(page.workers().length).toBe(0);
});
// Flaky: https://github.com/microsoft/playwright/issues/1300
it.fail(FFOX)('should report network activity', async function({page, server}) {
// flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496461538
it.fail(FFOX && LINUX)('should report network activity', async function({page, server}) {
const [worker] = await Promise.all([
page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html'),
Expand Down