feat(nowait): allow waitUntil:nowait for actions #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
nowait
branch
3 times, most recently
from
e1c4eba to
185054d
Compare
dgozman
approved these changes
Mar 6, 2020
| @@ -1115,7 +1117,7 @@ class PendingNavigationBarrier { | |||
|
|
|||
| async addFrame(frame: Frame) { | |||
| this.retain(); | |||
| await frame.waitForNavigation(this._waitOptions).catch(e => {}); | |||
| await frame.waitForNavigation(this._options as types.NavigateOptions).catch(e => {}); | |||
There was a problem hiding this comment.
Why 'as'? Are we passing non-compatible options? Seems suspicious.
There was a problem hiding this comment.
trimming the 'nowait' here...
src/frames.ts
Outdated
| @@ -100,7 +100,9 @@ export class FrameManager { | |||
| } | |||
| } | |||
|
|
|||
| async waitForNavigationsCreatedBy<T>(action: () => Promise<T>, options?: types.WaitForNavigationOptions): Promise<T> { | |||
| async waitForNavigationsCreatedBy<T>(action: () => Promise<T>, options?: types.ActionWaitOptionsNoWaitFor): Promise<T> { | |||
| if (options && options.waitUntil && options.waitUntil === 'nowait') | |||
There was a problem hiding this comment.
nit: no need to check options.waitUntil for truthy :)
docs/api.md
Outdated
| @@ -2174,6 +2194,13 @@ console.log(frame === contentFrame); // -> true | |||
| - y <[number]> | |||
| - `modifiers` <[Array]<"Alt"|"Control"|"Meta"|"Shift">> Modifier keys to press. Ensures that only these modifiers are pressed during the hover, and then restores current modifiers back. If not specified, currently pressed modifiers are used. | |||
| - `waitFor` <[boolean]> Whether to wait for the element to be present in the dom and displayed (for example, no `display:none`), stop moving (for example, wait until css transition finishes) and potentially receive pointer events at the click point (for example, wait until element becomes non-obscured by other elements). Defaults to `true`. | |||
| - `waitUntil` <"commit"|"load"|"domcontentloaded"|"networkidle0"|"networkidle2"|"nowait"> Actions that cause navigations are waiting for those navigations to `commit` by default. This behavior can be changed to either wait for another load phase or to omit the waiting altogether using `nowait`: | |||
docs/api.md
Outdated
| @@ -1276,6 +1280,13 @@ Shortcut for [page.mainFrame().goto(url[, options])](#framegotourl-options) | |||
| - y <[number]> | |||
| - `modifiers` <[Array]<"Alt"|"Control"|"Meta"|"Shift">> Modifier keys to press. Ensures that only these modifiers are pressed during the hover, and then restores current modifiers back. If not specified, currently pressed modifiers are used. | |||
| - `waitFor` <[boolean]> Whether to wait for the element to be present in the dom and displayed (for example, no `display:none`), stop moving (for example, wait until css transition finishes) and potentially receive pointer events at the click point (for example, wait until element becomes non-obscured by other elements). Defaults to `true`. | |||
| - `waitUntil` <"commit"|"load"|"domcontentloaded"|"networkidle0"|"networkidle2"|"nowait"> Actions that cause navigations are waiting for those navigations to `commit` by default. This behavior can be changed to either wait for another load phase or to omit the waiting altogether using `nowait`: | |||
There was a problem hiding this comment.
Why is hover waiting for navigaiton?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.