fix(test-runner): ESM compatibly on Windows #12615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Mar 9, 2022
rwoll
approved these changes
Mar 9, 2022
mxschmitt
changed the title
mxschmitt
force-pushed
the
devops-add-windows
branch
from
a568668 to
a1854ed
Compare
dgozman
reviewed
Mar 10, 2022
.github/workflows/tests_primary.yml
Outdated
| DEBUG: pw:install | ||
| - run: npm run build | ||
| - run: npx playwright install --with-deps | ||
| - run: npm run ttest -- --grep=esm |
There was a problem hiding this comment.
Let's follow https://playwright.dev/docs/test-annotations#tag-tests:
npm run ttest -- --grep=@esm
There was a problem hiding this comment.
was doing it with # because we used it for our smoke tests: #smoke. Shall I change #smoke -> @esm in a follow-up too.
mxschmitt
force-pushed
the
devops-add-windows
branch
from
ebe9097 to
520f5d8
Compare
mxschmitt
added a commit
to mxschmitt/playwright
that referenced
this pull request
Mar 10, 2022
mxschmitt
added a commit
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets keep ensuring that ESM and its friends are working because currently they are broken and users are affected.
Relates:
.tsextension when creating Playwright config for TypeScript projects sveltejs/kit#4194