browser(firefox): introduce SimpleChannel #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review URL: aslushnikov/juggler@6364381 Refactor inter-process communication inside Firefox. The goal is to have a single abstraction that works nicely for all our cross-process communication needs (browser <-> content, content <-> workers, content <-> file:// process, e.t.c.) This is step 1 that eliminates content sessions everywhere. Step 2 will move workers onto `SimpleChannel` as well. This is a pre-requisite for microsoft#720: with a single `browser <-> content` communication channel it will be easier to await permission change in tabs. References microsoft#720
|
Left some comments on the commit. |
dgozman
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review URL: aslushnikov/juggler@6364381
Refactor inter-process communication inside Firefox. The goal is
to have a single abstraction that works nicely for all our cross-process
communication needs (browser <-> content, content <-> workers, content
<-> file:// process, e.t.c.)
This is step 1 that eliminates content sessions everywhere.
Step 2 will move workers onto
SimpleChannelas well.This is a pre-requisite for #720: with a single
browser <-> contentcommunication channel it will be easier to await permission change in tabs.
References #720