Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a playwright-ready docker image #1161

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

aslushnikov
Copy link
Collaborator

No description provided.

@arjunattam
Copy link
Contributor

Should we replace/delete the dockerfiles in the .ci directory? I think they are confusing to new users, since they don't work with latest chrome/webkit/firefox.

@aslushnikov
Copy link
Collaborator Author

Should we replace/delete the dockerfiles in the .ci directory? I think they are confusing to new users, since they don't work with latest chrome/webkit/firefox.

Good point. Removed.

@pavelfeldman pavelfeldman merged commit 1781ae7 into microsoft:master Feb 28, 2020
@aslushnikov aslushnikov deleted the docker-image branch April 23, 2020 00:45
aslushnikov added a commit that referenced this pull request Jul 14, 2020
This adds a new script to calculate docker image size with
all parent layers.

Note: take this metrics with a grain of salt, since in reality
docker compresses and reuses layers.

Some historic stats obtained with this script:
- **`208MB`** (-33MB) chore(docker): skip "recommended" dependencies (#2917) (1cebf87)
- **`241MB`** (-29MB) chore(docker): trim some of the gstreamer dependencies (#2897) (bce4b1a)
- **`272MB`** (-1MB) devops: do cache busting for APT (#2656) (bb34418)
- **`273MB`** (+49MB) fix(webkit): update Docker file to include gstreamer (#2636) (5c6c659)
- **`224MB`** (+0MB) chore: fix emojis for CR and FF in Dockerfile (#2522) (24316ad)
- **`224MB`** (-1MB) fix: Dockerfile for Firefox (#1937) (b516ac4)
- **`225MB`** (+49MB) devops(docker): Install ffmpeg dependency, adding codecs necessary for video playback in Firefox (#1627) (222d01c)
-  **`176MB`** (+32MB) chore(docs): optionally install XVFB in docker(ec3ee66)
-  **`144MB`** (+144MB)  feat: add a playwright-ready docker image (#1161)(1781ae7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants