New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser(webkit): pause in popup until Target.resume is received #1134

Merged

dgozman merged 1 commit into microsoft:master from yury-s:wk-popup-pause

Feb 26, 2020

Member

yury-s commented Feb 26, 2020

yury-s/WebKit@e7f8b02

Also wait until WebPageProxy::Show in the emulation agent when setting size overrides for popups. Otherwise the size could be overridden with defaults that are set before ::Show.


          browser(webkit): pause in popup until Target.resume is received

4984c7e

dgozman approved these changes

View reviewed changes

dgozman merged commit 7a75754 into microsoft:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet