Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Firefox and Webkit dependencies to troubleshooting guide #1041

Closed
Tyriar opened this issue Feb 16, 2020 · 4 comments · Fixed by #1461
Closed

[Feature] Add Firefox and Webkit dependencies to troubleshooting guide #1041

Tyriar opened this issue Feb 16, 2020 · 4 comments · Fixed by #1461
Assignees

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 16, 2020

When the browser fails to launch you get redirected here:

https://github.com/Microsoft/playwright/blob/master/docs/troubleshooting.md

After some looking around I found https://github.com/microsoft/playwright/blob/master/.github/workflows/tests.yml that contains some dependencies on how to run firefox and webkit. I only managed to get firefox running on Azure Pipelines though, webkit still failed when I installed these packages:

- name: install required packages
run: |
sudo apt-get update
sudo apt-get install libwoff1 libopus0 libwebp6 libwebpdemux2 libenchant1c2a libgudev-1.0-0 libsecret-1-0 libhyphen0 libgdk-pixbuf2.0-0 libegl1 libgles2 libevent-2.1-6 libnotify4 libxslt1.1
sudo apt-get install xvfb

You can see the steps I went through in this PR: xtermjs/xterm.js#2722

@arjunattam arjunattam self-assigned this Feb 17, 2020
@arjunattam
Copy link
Contributor

Thanks for the suggestion @Tyriar, we should definitely add this. For now you could use this list. I've verified it to work for the 3 browsers, for Ubuntu 18.04 and Playwright 0.11.1.

@arjunattam
Copy link
Contributor

Taking a look at it! Any chance we could add { dumpio: true } to the browser launch method? That will report the missing dependencies.

Tyriar added a commit to Tyriar/playwright that referenced this issue Feb 18, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Feb 18, 2020

@arjun27 thanks, figured it out with dumpio (invalid browser args). That should definitely be mentioned in troubleshooting too. Created #1051 which I recommend doing across the public API to make the lib nicer to user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants