fix(webkit): emit close on pages before clearing them (#1386)

microsoft · Mar 13, 2020 · a96dec5 · a96dec5
1 parent 69be12a
commit a96dec5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/webkit/wkBrowser.ts b/src/webkit/wkBrowser.ts
@@ -68,9 +68,10 @@ export class WKBrowser extends platform.EventEmitter implements Browser {
   _onDisconnect() {
     for (const wkPage of this._wkPages.values())
       wkPage.dispose();
-    this._wkPages.clear();
     for (const context of this._contexts.values())
       context._browserClosed();
+    // Note: previous method uses pages to issue 'close' event on them, so we clear them after.
+    this._wkPages.clear();
     this.emit(Events.Browser.Disconnected);
   }