feat(roll): roll Playwright 1.15.0-next-1630006646000 #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
roll/1.15.0-next-1630006646000
branch
from
fc4e846 to
8384034
Compare
| @@ -3339,8 +3343,8 @@ async def is_hidden( | |||
| When true, the call requires selector to resolve to a single element. If given selector resolves to more then one | |||
| element, the call throws an exception. | |||
| timeout : Union[float, NoneType] | |||
| Maximum time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by | |||
| using the `browser_context.set_default_timeout()` or `page.set_default_timeout()` methods. | |||
| **DEPRECATED** This option is ignored. `frame.is_hidden()` does not wait for the element to become hidden and | |||
There was a problem hiding this comment.
DeprecationWarning should be emitted for this
| @@ -6873,6 +6879,9 @@ async def route( | |||
| Once routing is enabled, every request matching the url pattern will stall unless it's continued, fulfilled or aborted. | |||
|
|
|||
| > NOTE: The handler will only be called for the first url if the response is a redirect. | |||
| > NOTE: `page.route()` will not intercept requests intercepted by Service Worker. See | |||
| [this](https://github.com/microsoft/playwright/issues/1090) issue. We recommend disabling Service Workers when using | |||
| request interception. Via `await context.addInitScript(() => delete window.navigator.serviceWorker);` | |||
There was a problem hiding this comment.
The snippet should be of python not js/ts
There was a problem hiding this comment.
feel free to follow up upstream.
mxschmitt
force-pushed
the
roll/1.15.0-next-1630006646000
branch
from
6cefe89 to
d318c11
Compare
mxschmitt
force-pushed
the
roll/1.15.0-next-1630006646000
branch
from
d318c11 to
78c22eb
Compare
pavelfeldman
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is broken because of pypa/setuptools-scm#608