Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set docker image lineage and lifecycle annotations #192

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

ghidalgo3
Copy link
Contributor

@ghidalgo3 ghidalgo3 commented Mar 29, 2024

Description

There are metadata annotations we must set to inform downstream image consumers of image deprecation dates and lineage.

I tried to call the ORAS CLI via its docker container but found it much too difficult to pass docker credentials to it, so we just install it on the host.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested by running the cipublish several times, checked that:

  1. When a new image is pushed, it receives a lineage annotation.
  2. When an image replaces an existing image, the previous image receives a lifecycle annotation.
  3. We check the existence of annotations to make sure we don't add duplicate annotations.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Documentation has been updated

@ghidalgo3 ghidalgo3 marked this pull request as ready for review March 29, 2024 16:44
@ghidalgo3 ghidalgo3 merged commit 9874f04 into main Mar 29, 2024
3 checks passed
@ghidalgo3 ghidalgo3 deleted the guhidalgo/dockerimagelineage branch March 29, 2024 21:08
@ghidalgo3 ghidalgo3 mentioned this pull request May 1, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants