Use conda for tiler dependencies, support LERC rasters #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mamba user needs to write on the module directories in order to update the egg.info dir.
mmcfarland
changed the title
TomAugspurger
approved these changes
Apr 10, 2023
Comment on lines
+7
to
+8
| RUN python3 -m pip install -r requirements-dev.txt | ||
| RUN python3 -m pip install -e ./pccommon -e ./pctiler |
There was a problem hiding this comment.
Just a note that these lines are slightly risky, in that something in pip-land could decide to (re-)install that something that we expect to get from conda (like rasterio).
I manually verified that things were working as expected (that pip wasn't installing rasterio) but things might change in the future, and we wouldn't necessarily know until stuff breaks.
mmcfarland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wheels built for rasterio 1.3 to not include a GDAL build that supports LERC geotiffs. This is essentially a breaking change for us, as previous versions did (apparently unintentionally) support that codec. This PR changes the Python dependency management to source rasterio from conda which includes a LERC supported build.
This can likely be reverted if/when a rasterio release gains support.
xref: rasterio/rasterio-wheels#100
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests continue to pass and manually tested against 3dep HAG tiffs from production which currently fail on main HEAD.
Checklist:
Please delete options that are not relevant.