Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display JIT Allocated Heap Size #1289

Merged
merged 9 commits into from
Nov 10, 2020
Merged

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Oct 14, 2020

Added a new event MethodJitMemoryAllocatedForCode in dotnet/runtime#44030 to log the JIT 's memory request for code. This PR displays that information in PerfView.

Here is the screenshot:

image

Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalspathak, this is looking good. A few comments/questions.

src/PerfView/JitStats.cs Outdated Show resolved Hide resolved
src/TraceEvent/Computers/TraceManagedProcess.cs Outdated Show resolved Hide resolved
src/TraceEvent/Computers/TraceManagedProcess.cs Outdated Show resolved Hide resolved
src/TraceEvent/Computers/TraceManagedProcess.cs Outdated Show resolved Hide resolved
src/TraceEvent/Computers/TraceManagedProcess.cs Outdated Show resolved Hide resolved
@kunalspathak kunalspathak marked this pull request as ready for review October 14, 2020 20:34
@kunalspathak
Copy link
Member Author

@brianrob - I think this should be ready for review.

Copy link
Member

@brianrob brianrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge this once the corresponding runtime change is merged.

@kunalspathak
Copy link
Member Author

@brianrob - dotnet/runtime#44030 is merged now.

@brianrob brianrob merged commit 24ba662 into microsoft:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants