Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles for TensorRT, CUDA, build from source #922

Merged
merged 16 commits into from
Jul 9, 2019
Merged

Dockerfiles for TensorRT, CUDA, build from source #922

merged 16 commits into from
Jul 9, 2019

Conversation

vinitra-zz
Copy link

  • Restructuring dockerfile README
  • Adding 3 dockerfiles used for AzureML BYOC scenario

@vinitra-zz vinitra-zz requested a review from a team as a code owner April 26, 2019 19:48
manashgoswami
manashgoswami previously approved these changes Apr 26, 2019
View reviewed changes
jywu-msft
jywu-msft requested changes Apr 29, 2019
View reviewed changes
Copy link
Member

@jywu-msft jywu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HectorSVC and I left some additional review comments on how to optimize further.
Thanks!

@jywu-msft jywu-msft mentioned this pull request Jun 13, 2019
Merged
HectorSVC
HectorSVC previously approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vinitra-zz vinitra-zz requested a review from jywu-msft July 1, 2019 18:33
@vinitra-zz vinitra-zz requested review from tianchijushi and HectorSVC and removed request for jywu-msft July 2, 2019 17:12
jywu-msft
jywu-msft reviewed Jul 8, 2019
View reviewed changes
dockerfiles/README.md Outdated Show resolved Hide resolved
@vinitra-zz
Copy link
Author

Hi @jywu-msft! Addressed your comments in the latest update. Should we include the onnx package as part of the docker image? As of now it only contains the onnxruntime build.

@jywu-msft
Copy link
Member

Hi @jywu-msft! Addressed your comments in the latest update. Should we include the onnx package as part of the docker image? As of now it only contains the onnxruntime build.

shouldn't need onnx package.

@jywu-msft jywu-msft merged commit 6b32c77 into microsoft:master Jul 9, 2019
@vinitra-zz vinitra-zz deleted the docker-mcr-update branch July 9, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywu-msft jywu-msft jywu-msft approved these changes

@manashgoswami manashgoswami manashgoswami left review comments

@tianchijushi tianchijushi Awaiting requested review from tianchijushi

@HectorSVC HectorSVC Awaiting requested review from HectorSVC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinitra-zz @jywu-msft @manashgoswami @HectorSVC @vinitra