Ryanunderhill/c api #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Ptr suffix and use '*' syntax directly.
…o ryanunderhill/c_api
yuanbyu
previously approved these changes
Dec 4, 2018
snnn
reviewed
Dec 4, 2018
| @@ -13,7 +13,7 @@ | |||
| #include "core/common/exceptions.h" | |||
| #include "core/common/status.h" | |||
| #include "core/framework/fence.h" | |||
| #include "core/framework/allocator_info.h" | |||
| #include "core/session/onnxruntime_c_api.h" | |||
There was a problem hiding this comment.
onnxruntime_framework shouldn't depend on any file in session folder.
snnn
reviewed
Dec 4, 2018
snnn
reviewed
Dec 4, 2018
| @@ -40,20 +40,19 @@ DECLARE_DEFAULT_DELETER_FOR_ONNX_OBJECT(Allocator); | |||
| DECLARE_DEFAULT_DELETER_FOR_ONNX_OBJECT(TensorTypeAndShapeInfo); | |||
| DECLARE_DEFAULT_DELETER_FOR_ONNX_OBJECT(RunOptions); | |||
| DECLARE_DEFAULT_DELETER_FOR_ONNX_OBJECT(SessionOptions); | |||
| DECLARE_DEFAULT_DELETER_FOR_ONNX_OBJECT(ProviderFactoryPtr); | |||
There was a problem hiding this comment.
It originally caused an error because there is no ProviderFactory* but there is ProviderFactoryInterface*, I put it back.
…o ryanunderhill/c_api
|
What's the benefit of merging them into a single header file? |
yuanbyu
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change merges all of the C API header files into a single header file.
It also removes the Ptr suffix on C API types and uses '*' notation directly.
The changes in most files are just due to naming changes and header file include changes.
There will be more changes soon.