[wasm] upgrade emsdk version to 2.0.23 #7893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good luck! If onnx runtime can be built with llvm 12... GPU part doesn't work. CPU-only code probably is fine. |
Yes and fortunately we are not going to use CUDA in web assembly anyway. |
snnn
reviewed
Jun 1, 2021
hanbitmyths
reviewed
Jun 2, 2021
| @@ -629,6 +629,8 @@ if (onnxruntime_BUILD_UNIT_TESTS) | |||
| add_subdirectory(${PROJECT_SOURCE_DIR}/external/googletest EXCLUDE_FROM_ALL) | |||
| set_msvc_c_cpp_compiler_warning_level(3) | |||
| set_target_properties(gmock PROPERTIES FOLDER "External/GTest") | |||
| # disable treating all warnings as errors for gmock | |||
| target_compile_options(gmock PRIVATE "-w") | |||
There was a problem hiding this comment.
Is this intentionally for all builds?
There was a problem hiding this comment.
It's fine. We don't want to and will not fix any of the warnings.
snnn
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: upgrade emsdk to 2.0.23.
-Wno-deprecated-copyfor gmock (otherwise it will fail the build for webassembly)