Div mul fusion #7183
Merged
Div mul fusion #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orttraining/orttraining/core/optimizer/graph_transformer_utils.cc
Outdated
Show resolved
Hide resolved
ashbhandare
added
the
training
ashbhandare
force-pushed
the
aibhanda/div_mul
branch
2 times, most recently
from
8858f7e to
e284fd5
Compare
SherlockNoMad
previously approved these changes
Apr 1, 2021
ashbhandare
force-pushed
the
aibhanda/div_mul
branch
from
e284fd5 to
2911ad8
Compare
ytaous
reviewed
Apr 1, 2021
ashbhandare
force-pushed
the
aibhanda/div_mul
branch
from
2911ad8 to
8d3625d
Compare
ytaous
approved these changes
Apr 2, 2021
|
Amusingly, many GPU's then (internally) decompose X2/X1 back into (1/X1 * X2). 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This transform fuses Div->Mul when the computation is (1/X1 * X2) to do Div (X2/X1)