Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import more featurizers #2781

Merged
merged 10 commits into from
Jan 6, 2020
Merged

Import more featurizers #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
98936ab
Make kernels non-template. Add input constraint for learnt data.
yuslepukhin Jan 2, 2020
8d93344
Add two more featurizers along with tests. Tests fail.
yuslepukhin Jan 3, 2020
8be3fcb
Fix tests serialized stream by prepending version bytes.
yuslepukhin Jan 3, 2020
97eb658
Add inputation_marker_transfomer and the test.
yuslepukhin Jan 3, 2020
3fb8952
Added label_encoder_transformer along with a test.
yuslepukhin Jan 4, 2020
5c477bd
Fix labelencodertransfomer_test.cc string_throw case
yuslepukhin Jan 4, 2020
085918f
Add MissingDummiesTransformer along with the test.
yuslepukhin Jan 4, 2020
13255cd
Remove commented code.
yuslepukhin Jan 6, 2020
e692677
Merge branch 'master' into yuslepukhin/import_featurizers
yuslepukhin Jan 6, 2020
f4df726
Update manifest.
yuslepukhin Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cgmanifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@
{
"component": {
"git": {
"commitHash": "3f0f9802553944b75015aad098d856b2d17220df",
"commitHash": "a11f5002af58a03d5902b13ef65c84cedb499024",
"repositoryUrl": "https://github.com/microsoft/FeaturizersLibrary.git"
},
"type": "git"
Expand Down
9 changes: 3 additions & 6 deletions cmake/external/featurizers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@
# This source code should not depend on the onnxruntime and may be built independently

set(featurizers_URL "https://github.com/microsoft/FeaturizersLibrary.git")
set(featurizers_TAG "3f0f9802553944b75015aad098d856b2d17220df")
set(featurizers_TAG "a11f5002af58a03d5902b13ef65c84cedb499024")

set(featurizers_pref FeaturizersLibrary)
set(featurizers_ROOT ${PROJECT_SOURCE_DIR}/external/${featurizers_pref})
set(featurizers_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/external/${featurizers_pref})

# Only due to GIT_CONFIG
# Uncoment UPDATE_COMMAND if you work locally
# on the featurizers so cmake does not undo your changes.
# Windows required git config setting
# and an a switch whether we link to MSVCRT statically or dynamically
if (WIN32)
ExternalProject_Add(featurizers_lib
PREFIX ${featurizers_pref}
Expand All @@ -24,7 +23,6 @@ if (WIN32)
SOURCE_SUBDIR src/Featurizers
BINARY_DIR ${featurizers_BINARY_DIR}
CMAKE_ARGS -Dfeaturizers_MSVC_STATIC_RUNTIME=${onnxruntime_MSVC_STATIC_RUNTIME}
# UPDATE_COMMAND ""
INSTALL_COMMAND ""
)
else()
Expand All @@ -37,7 +35,6 @@ else()
SOURCE_SUBDIR src/Featurizers
BINARY_DIR ${featurizers_BINARY_DIR}
CMAKE_ARGS -DCMAKE_POSITION_INDEPENDENT_CODE=ON
# UPDATE_COMMAND ""
INSTALL_COMMAND ""
)
endif()
Expand Down
Loading