add op_types_to_quantize to get_qnn_qdq_config #23458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onnxruntime/python/tools/quantization/execution_providers/qnn/quant_config.py
Outdated
Show resolved
Hide resolved
added 2 commits
January 24, 2025 17:38
adrianlizarraga
previously approved these changes
Jan 24, 2025
|
Looks like there are some linter errors. Should be able to fix them by running |
Never thought it should be written in this way.. |
|
Hi @xieofxie, could you please try merging the latest changes from main? That should get the CI working. |
Sure, merged @adrianlizarraga Just resolved conflict, please take a look, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add op_types_to_quantize to get_qnn_qdq_config so support only quantize part of it.
In my understanding, if ops are not quantized, they will use fp16 to run if supported?
https://docs.qualcomm.com/bundle/publicresource/topics/80-63442-50/SupportedOps.html
Motivation and Context
See scenario in issue in Olive microsoft/Olive#1552