Ryanunderhill/concat neg axis #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ryanunderhill/concat_neg_axis
…o ryanunderhill/concat_neg_axis
…o ryanunderhill/concat_neg_axis
|
Does the spec say the axis can be negative ? |
snnn
approved these changes
Dec 13, 2018
| @@ -36,19 +39,19 @@ Status ConcatBase::PrepareForCompute(OpKernelContext* ctx, int input_count, Prep | |||
| for (int index = 0; index < input_count; index++) { | |||
| tensor_pointer = ctx->Input<Tensor>(index); | |||
| if (tensor_pointer == nullptr) return Status(common::ONNXRUNTIME, common::FAIL, "input count mismatch"); | |||
| concat_axis_size += tensor_pointer->Shape()[int(axis_)]; | |||
| concat_axis_size += tensor_pointer->Shape()[int(axis)]; | |||
There was a problem hiding this comment.
Because the operator[] for Shape() didn't take int64_t initially so it used to give errors. That was back when it was first written. I can change it and see if you want me to.
| @@ -63,7 +66,7 @@ Status ConcatBase::PrepareForCompute(OpKernelContext* ctx, int input_count, Prep | |||
|
|
|||
| // The input_axis_pitch is the number of elements to add to move to the next split axis in the input | |||
| int64_t input_axis_pitch = 1; | |||
| for (int i = int(data_n.Shape().NumDimensions()); i-- > axis_;) | |||
| for (int i = int(data_n.Shape().NumDimensions()); i-- > axis;) | |||
There was a problem hiding this comment.
Would static_cast(...) be better than int(...) ?
There was a problem hiding this comment.
Maybe 'auto i' would be better. Is there a difference in this case?
There was a problem hiding this comment.
No difference.
It doesn't conform our coding style:
https://google.github.io/styleguide/cppguide.html#Casting
souptc
pushed a commit
that referenced
this pull request
Dec 17, 2018
Another set of simple ops Plus change the ceil/floor implementations to use Eigen since I figured out a way Related work items: #152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add negative axis support to concat