Remove special casing of "None" as a dim_param #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
commented
Jul 24, 2019
| @@ -114,12 +114,12 @@ def testRunModelSymbolicInput(self): | |||
| self.assertEqual(input_name, "X") | |||
| input_shape = sess.get_inputs()[0].shape | |||
| # Input X has an unknown dimension. | |||
| self.assertEqual(input_shape, [None, 2]) | |||
| self.assertEqual(input_shape, ['None', 2]) | |||
There was a problem hiding this comment.
Without the special case treatment, the output now has the dim_param value in quotes. The previous output was the python None for a null.
gramalingam
approved these changes
Jul 24, 2019
ke1337
approved these changes
Jul 24, 2019
linkerzhang
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove special case handling of "None" as a dim_param
Motivation and Context
Special casing of a specific dim_param string is problematic long term and the issue around using "None" as a dim_param for different values is limited to the skl2onnx converter.