Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the resize and upsample #1426

Merged
merged 8 commits into from
Jul 24, 2019
Merged

Optimize the resize and upsample #1426

merged 8 commits into from
Jul 24, 2019

Conversation

yufenglee
Copy link
Member

@yufenglee yufenglee commented Jul 17, 2019

Description: Describe your changes.
Optimize the resize and upsample operators
Motivation and Context

  • Why is this change required? What problem does it solve?
    For case with input with shape [1,128, 267, 200] and scales [1, 1, 1.97, 2], Resize and upsample get 15x gain (w/o: 1020ms, w: 71ms on my local box). It should benefit other scenarios at similar level.
  • If it fixes an open issue, please link to the issue here.

@yufenglee yufenglee requested a review from a team as a code owner July 17, 2019 21:19
@linkerzhang
Copy link
Contributor

thanks! do you mind to share numbers if any for this improvement please?

@yufenglee
Copy link
Member Author

thanks! do you mind to share numbers if any for this improvement please?

Added in the PR description section.

@yufenglee yufenglee requested a review from a team July 23, 2019 22:03
@skottmckay
Copy link
Contributor

Can we add one more very simple change, that being to check if any work is required? e.g. ssd_mobilenet in mlperf has a resize that does nothing as the input size matches the resize, but nothing checks if all the scales values are 1.0.

@yufenglee yufenglee merged commit bb26865 into master Jul 24, 2019
@yufenglee
Copy link
Member Author

Can we add one more very simple change, that being to check if any work is required? e.g. ssd_mobilenet in mlperf has a resize that does nothing as the input size matches the resize, but nothing checks if all the scales values are 1.0.

Just saw the comment. Adding it in a new PR.

@yufenglee yufenglee deleted the roli/resize branch July 24, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants