Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package pipelines to support TRT 8.5 #13998

Merged
merged 6 commits into from
Dec 16, 2022
Merged

Update package pipelines to support TRT 8.5 #13998

merged 6 commits into from
Dec 16, 2022

Conversation

chilo-ms
Copy link
Contributor

@chilo-ms chilo-ms commented Dec 16, 2022

@chilo-ms chilo-ms marked this pull request as ready for review December 16, 2022 07:55
@chilo-ms chilo-ms requested a review from a team as a code owner December 16, 2022 07:55
Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that the code is not compatible with TRT 8.4?

@chilo-ms
Copy link
Contributor Author

Does it mean that the code is not compatible with TRT 8.4?

yes, I'm afraid so. UINT8 type is just supported by TRT 8.5.
onnx/onnx-tensorrt#879
#12570

@snnn
Copy link
Member

snnn commented Dec 16, 2022

Then should the old docker files be deleted?

  • Dockerfile.ubuntu_cuda11_4_tensorrt8_0
  • Dockerfile.ubuntu_cuda11_4_tensorrt8_2
  • Dockerfile.ubuntu_cuda11_6_tensorrt8_4

Whenever you need them, you still can find them from git history.

@chilo-ms
Copy link
Contributor Author

chilo-ms commented Dec 16, 2022

  • ubuntu_cuda11_6_tensorrt8_4

The perf dashboard/CI is still using those docker files.
https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/python/tools/tensorrt/perf/build/build_image.py#L16

Later might discuss whether to stop running the perf tests on older TRT and then will remove those files.

jywu-msft
jywu-msft previously approved these changes Dec 16, 2022
@@ -2,7 +2,7 @@
# Label: com.nvidia.cuda.version: 11.6.1
# Label: com.nvidia.cudnn.version: 8.4.0
# Ubuntu 20.04
FROM nvidia/cuda:11.6.1-cudnn8-devel-ubuntu20.04
FROM nvidia/cuda:11.8.0-cudnn8-devel-ubuntu20.04 AS base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: The AS base is not needed since this dockerfile does not have another FROM statement that builds upon this subimage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@chilo-ms chilo-ms merged commit ba89cae into main Dec 16, 2022
@chilo-ms chilo-ms deleted the trt_ci_fix branch December 16, 2022 23:01
henrywu2019 pushed a commit to henrywu2019/onnxruntime that referenced this pull request Dec 26, 2022
mszhanyi added a commit that referenced this pull request Jan 4, 2023
mszhanyi added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants