Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TensorRT EP] support TensorRT 8.5 #13867
[TensorRT EP] support TensorRT 8.5 #13867
Changes from 43 commits
a5971f0
4d11ee8
fa2a58a
ce021a2
b82948d
8c1bb7f
0dd1129
1514ff9
42666d3
de0f435
5a217de
4f5ef22
0677f5e
9288869
100b934
331a947
f59bd59
26d9c84
50d583a
7494080
c59a421
cade3ab
48d66ff
10611cb
948279a
a21b306
ff83678
ea0c763
01741c1
c32458c
2bcdef4
9c199c1
e1d6aaf
af7d169
35ab897
a1fded4
a62f6e1
d7c7ba7
0e89046
63d664b
f390402
5fc64ca
ed16a9b
61fdf47
11c9d29
c3376d9
ba4b59e
af57f18
68c185d
f3ccdd6
8b63162
ffce45c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave a comment indicating which branch it's from. previously there was a comment for 8.4-GA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the impact of this?
how much did test time increase and what test coverage do we lose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make the timeout configurable and schedule a daily run which runs through all the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test time is 2.5 hours for TRT 8.4 to finish, but it increases to more than 9 hours for TRT 8.5 still not even finished. (I think it needs several more hours to finish)
With this change, we won't test any unit tests instead of
TensorrtExecutionProviderTest
, but we will run model tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can.