Make sure submodule urls are up-to-date #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
previously approved these changes
Jul 8, 2019
|
@skottmckay I realized that I was missing the |
skottmckay
approved these changes
Jul 8, 2019
|
/azp run |
|
Azure Pipelines successfully started running 22 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This extends build.py to run
git submodule sync --recursivebefore runninggit submodule update --init --recursive. This makes sure submodule URLs are up-to-date.Motivation and Context
Recently, the submodule URL for tvm changed. If you have an existing clone of the repository, then running build.sh/build.py will not update to the new URL and
git submodule update --init --recursivewill raise an error as it doesn't find the submodule commit in the old repo.