remove unused core/util/math.h routines #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracysh
changed the title
snnn
approved these changes
Jul 8, 2019
SherlockNoMad
pushed a commit
that referenced
this pull request
Jan 7, 2020
This reverts commit 3a58886.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change removes a number of unused math helpers from core/util/math.h. Most operators are already using MLAS or Eigen directly.
Motivation and Context
This is the first of a few changes to clean up the math.h interface and the mixed inclusion of mlas.h with other BLAS headers. This first change just scopes down the problem by removing the stuff that isn't in use already.