Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM64 build + Add NuGet pipeline including ARM binaries #1335

Merged
merged 13 commits into from
Jul 11, 2019

Conversation

jignparm
Copy link
Contributor

@jignparm jignparm commented Jul 2, 2019

Description: --arm64 build requires changes to CMakeLists.txt to pass. Also, adding a NuGet pipeline to include arm binaries into package.

Motivation and Context
This PR fixes the --arm64 cross-compile build option, by commenting out an error-generating flag in CMakeLists.txt. Also adds a new pipeline to package arm64 compiled bits.

@jignparm jignparm requested a review from a team as a code owner July 2, 2019 23:57
cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@snnn
Copy link
Member

snnn commented Jul 8, 2019

Please see https://github.com/microsoft/onnxruntime/blob/master/cmake/CMakeLists.txt#L436 and https://github.com/microsoft/onnxruntime/blob/master/cmake/CMakeLists.txt#L455. I would recommend solve it in that way. So that we don't need to add an extra cmake option.

@jignparm
Copy link
Contributor Author

jignparm commented Jul 8, 2019

Please see https://github.com/microsoft/onnxruntime/blob/master/cmake/CMakeLists.txt#L436 and https://github.com/microsoft/onnxruntime/blob/master/cmake/CMakeLists.txt#L455. I would recommend solve it in that way. So that we don't need to add an extra cmake option.

Good comment. Updated to reduce flags in CMakeLists.

@jignparm jignparm merged commit e580b76 into master Jul 11, 2019
@jignparm jignparm deleted the add_arm64_pipeline branch July 11, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants