-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory footprint of nGraph #1296
Conversation
(Merge branch 'jfdong/fix-ngraph-memory' into jfdong_ngraph_memfix)
/azp run |
Azure Pipelines successfully started running 22 pipeline(s). |
Can you quantify how much improvement this patch achieves? |
Do we need to patch or could we update the ngraph version we're using instead? |
Updating ngraph version is a bigger effort. I believe there are other issues with newer ngraph versions that are being tracked as separate issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove email header?
@jywu-msft we will remove the header. @skottmckay I agree with @jywu-msft , there is bigger effort of nGraph update. This patch will help during the interim. |
/azp run |
Azure Pipelines successfully started running 22 pipeline(s). |
@jywu-msft @pranavsharma |
@jywu-msft not merging this yet in case you want to run some tests or have other concerns. |
@jdfong thanks for the CLX numbers. Would it be possible for you to verify and provide expected numbers on AVX2 (on older system such as Haswell/Broadwell) One if our devs wasn't able to repro the resnet50 memory behavior on his system with AVX2. |
@sreekanth-yalachigere re: your comment about mkl-dnn EP mem usage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look. good. we should look at further reducing memory footprint. goal is to be as close to default cpu provider as possible.
Description: CMake changes to properly configure ngraph build.
Motivation and Context
Memory use of the onnxruntime (using the ngraph EP) on Windows is higher than it is on Linux. The included change attempts to narrow this gap.