-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use manylinux2010 image to build linux python wheels #1282
Conversation
Probably also fixes #1113 |
/azp run |
tools/ci_build/github/linux/docker/scripts/install_manylinux2010.sh
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 22 pipeline(s). |
c4db9fa
to
fc35293
Compare
Thanks for the work! The manylinux2010 and auditwheel really helps our distribution. I queued it in release pipeline for validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks the changes in cmake is breaking the Windows build. I'll take a look tomorrow
I pushed a new commit reverting a change introduced in |
I'll unblock the Windows failure tomorrow (some build environment related issue). Sorry for the delay.. |
Hi @mayeut could you pull ziya/update-cuda branch to unblock the windows build? I already altered the VMs for cuda 10. |
For the Linux fail on mnist model, it's a known flaky case (we are looking into it) and we will check in your PR first. |
Allow wheels built to truly be compliant with a manylinux policy
@raymondxyang, done |
/azp run |
Azure Pipelines successfully started running 22 pipeline(s). |
Thanks for the contribution :))) |
ln -s python /opt/onnxruntime-python/bin/python${PYTHON_VER} | ||
fi | ||
python -m pip install --upgrade --force-reinstall pip==19.1.1 | ||
python -m pip install --upgrade --force-reinstall numpy==1.16.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line must be fixed. @raymondxyang
Description: Use manylinux2010 docker image to build linux python wheels.
Motivation and Context
Before this change, linux wheels were built on Ubuntu 16.04 and were renamed manylinux1 wheels in order to be uploaded to PyPI. However, they do not respect the manylinux1 policy and the result is that
pip install onnxruntime
install those none compliant packages on system that don't support them. Building on manylinux2010 docker image allow wheels built to truly be compliant with a manylinux policy in order to provide onnxruntime to a wider audience.This fixes Need CentOS support #1001