Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use manylinux2010 image to build linux python wheels #1282

Merged
merged 10 commits into from
Jun 27, 2019

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Jun 23, 2019

Description: Use manylinux2010 docker image to build linux python wheels.

Motivation and Context

  • Why is this change required? What problem does it solve?
    Before this change, linux wheels were built on Ubuntu 16.04 and were renamed manylinux1 wheels in order to be uploaded to PyPI. However, they do not respect the manylinux1 policy and the result is that pip install onnxruntime install those none compliant packages on system that don't support them. Building on manylinux2010 docker image allow wheels built to truly be compliant with a manylinux policy in order to provide onnxruntime to a wider audience.
  • If it fixes an open issue, please link to the issue here.
    This fixes Need CentOS support #1001

@mayeut mayeut requested a review from a team as a code owner June 23, 2019 14:29
@mayeut
Copy link
Contributor Author

mayeut commented Jun 23, 2019

Probably also fixes #1113

@snnn
Copy link
Member

snnn commented Jun 23, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 22 pipeline(s).

setup.py Show resolved Hide resolved
@mayeut mayeut force-pushed the manylinux2010 branch 2 times, most recently from c4db9fa to fc35293 Compare June 24, 2019 04:28
@snnn snnn requested review from raymondxyang and jywu-msft June 24, 2019 05:55
@raymondxyang
Copy link

Thanks for the work! The manylinux2010 and auditwheel really helps our distribution. I queued it in release pipeline for validation.

Copy link

@raymondxyang raymondxyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks the changes in cmake is breaking the Windows build. I'll take a look tomorrow

@mayeut
Copy link
Contributor Author

mayeut commented Jun 25, 2019

I pushed a new commit reverting a change introduced in cmake/CMakeLists.txt. It should solve the windows issue.

@raymondxyang
Copy link

raymondxyang commented Jun 26, 2019

I'll unblock the Windows failure tomorrow (some build environment related issue). Sorry for the delay..

@raymondxyang
Copy link

Hi @mayeut could you pull ziya/update-cuda branch to unblock the windows build? I already altered the VMs for cuda 10.

@raymondxyang
Copy link

For the Linux fail on mnist model, it's a known flaky case (we are looking into it) and we will check in your PR first.

Raymond Yang and others added 2 commits June 26, 2019 11:37
Allow wheels built to truly be compliant with a manylinux policy
@mayeut
Copy link
Contributor Author

mayeut commented Jun 26, 2019

Hi @mayeut could you pull ziya/update-cuda branch to unblock the windows build? I already altered the VMs for cuda 10.

@raymondxyang, done

@raymondxyang
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 22 pipeline(s).

@raymondxyang raymondxyang merged commit 04d5819 into microsoft:master Jun 27, 2019
@raymondxyang
Copy link

Thanks for the contribution :)))

ln -s python /opt/onnxruntime-python/bin/python${PYTHON_VER}
fi
python -m pip install --upgrade --force-reinstall pip==19.1.1
python -m pip install --upgrade --force-reinstall numpy==1.16.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must be fixed. @raymondxyang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need CentOS support
3 participants