-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #10932
Update CODEOWNERS #10932
Conversation
Should we consider using teams instead? |
Good suggestion! I don't have admin privileges. You may propose it to Faith or Pranav. |
@faxu @pranavsharma What do you think of setting up some onnxruntime teams for code owners management? |
We could create these, but does it have different read/write/access permissions or is just as FYI for code area ownership? |
It is more than just FYI. It controls the required reviewers for owned files. |
I think we should make good use of the OWNER file. Because in this project different developers quickly tend to specialize or have deep knowledge about certain portions of the code. We want to make sure every code change is reviewed by the right people. For example, I'm not the right people to review training related changes. I can make comments or approve such changes, but they also should get an approval from the people who know the component most. |
Description:
Update CODEOWNERS, mainly because the one in master branch has invalid aliases. People come and go in life and that's ok because nothing lasts forever.
Motivation and Context