Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #10932

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Update CODEOWNERS #10932

merged 1 commit into from
Mar 18, 2022

Conversation

snnn
Copy link
Member

@snnn snnn commented Mar 18, 2022

Description:

Update CODEOWNERS, mainly because the one in master branch has invalid aliases. People come and go in life and that's ok because nothing lasts forever.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@edgchen1
Copy link
Contributor

@snnn snnn merged commit c29d943 into master Mar 18, 2022
@snnn snnn deleted the snn/cleanup branch March 18, 2022 16:37
@snnn
Copy link
Member Author

snnn commented Mar 18, 2022

Should we consider using teams instead? https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams

Good suggestion! I don't have admin privileges. You may propose it to Faith or Pranav.

@edgchen1
Copy link
Contributor

Should we consider using teams instead? https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams

Good suggestion! I don't have admin privileges. You may propose it to Faith or Pranav.

@faxu @pranavsharma What do you think of setting up some onnxruntime teams for code owners management?

@faxu
Copy link
Contributor

faxu commented Mar 18, 2022

We could create these, but does it have different read/write/access permissions or is just as FYI for code area ownership?
If the latter, it's the same overhead as maintaining a text file. I would actually suggest moving this to the wiki so you don't need to run CI for changes.

@edgchen1
Copy link
Contributor

We could create these, but does it have different read/write/access permissions or is just as FYI for code area ownership? If the latter, it's the same overhead as maintaining a text file. I would actually suggest moving this to the wiki so you don't need to run CI for changes.

It is more than just FYI. It controls the required reviewers for owned files.
More info here: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@snnn
Copy link
Member Author

snnn commented Mar 19, 2022

I think we should make good use of the OWNER file. Because in this project different developers quickly tend to specialize or have deep knowledge about certain portions of the code. We want to make sure every code change is reviewed by the right people. For example, I'm not the right people to review training related changes. I can make comments or approve such changes, but they also should get an approval from the people who know the component most.

lavanyax pushed a commit to intel/onnxruntime that referenced this pull request Mar 29, 2022
seddonm1 pushed a commit to seddonm1/onnxruntime that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants