review comments

microsoft · Jan 31, 2023 · dd70c88 · dd70c88
1 parent 89bbc3b
commit dd70c88
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/onnxruntime/python/tools/transformers/convert_generation.py b/onnxruntime/python/tools/transformers/convert_generation.py
@@ -483,9 +483,7 @@ def t5_to_onnx(args: argparse.Namespace):
         Path(args.output).parent,
         use_gpu=args.use_gpu,
         use_external_data_format=args.use_external_data_format,
-        optimize_onnx=True
-        if not args.precision == Precision.FLOAT16
-        else False,  # Enable the fp32 optimizations for now.
+        optimize_onnx=(args.precision != Precision.FLOAT16),
         precision=args.precision,
         verbose=False,
         use_decoder_start_token=False,

diff --git a/onnxruntime/python/tools/transformers/models/t5/t5_helper.py b/onnxruntime/python/tools/transformers/models/t5/t5_helper.py
@@ -245,7 +245,7 @@ def optimize_onnx(
             model_type="t5",
             num_heads=num_attention_heads,
             hidden_size=hidden_size,
-            opt_level=2 if not is_float16 else 0,
+            opt_level=2 if not is_float16 and not use_external_data_format else 0,
             optimization_options=optimization_options,
             use_gpu=False,
         )