Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#310 Default to requiring tab to trigger a completion #445

Merged
merged 2 commits into from
Sep 14, 2015

Conversation

mousetraps
Copy link
Contributor

Remove the custom committed-by characters setting and also default to
requiring tab/enter triggering a completion. This simplifies settings,
is consistent with both C# and JS projects in VS2015, and makes it easier
to work with identifiers that don't appear in the completions list.

Fix #310, related to #179

Remove the custom committed-by characters setting and also default to
requiring tab/enter triggering a completion. This simplifies settings,
is consistent with both C# and JS projects in VS2015, and makes it easier
to work with identifiers that don't appear in the completions list.
@mousetraps
Copy link
Contributor Author

screenshot:
image

mousetraps added a commit that referenced this pull request Sep 14, 2015
#310 Default to requiring tab to trigger a completion
Remove the custom committed-by characters setting and also default to
requiring tab/enter triggering a completion. This simplifies settings,
is consistent with both C# and JS projects in VS2015, and makes it easier
to work with identifiers that don't appear in the completions list.

Fix #310, related to #179
@mousetraps mousetraps merged commit 370d1ab into microsoft:master Sep 14, 2015
@billti
Copy link
Member

billti commented Sep 15, 2015

👍 Please wait for a code review and thumbs up this close to RTM though before merging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants