Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PciFunction to 0xFFFF for _PRT per specification #258

Merged

Conversation

Javagedes
Copy link
Contributor

Description

partially reverts #37 which updated the PciFunction to no longer be 0xFFFF for _PRT which goes against the ACPI specification that states that the PciFunction should be 0xFFFF for _PRT.

This is per ACPI specification 6.4 section 6.2.13

image

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

N/A - Spec compliance

Integration Instructions

Platforms should verify PciFunction for _PRT is 0xFFFF

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 25, 2024
partially reverts microsoft#37 which updated the PciFunction to no longer be
0xFFFF for _PRT which goes against the ACPI specification that states
that the PciFunction should be 0xFFFF for _PRT.
@Javagedes Javagedes force-pushed the bugfix-pci-function-prt branch from fa4fce2 to 8c1579e Compare July 25, 2024 19:21
@os-d os-d requested review from cfernald, JoeLopez333 and kuqin12 July 25, 2024 19:54
@Javagedes Javagedes merged commit 5e3536d into microsoft:release/202311 Jul 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants