[Rebase & FF] Adding support to build with CLANGPDB #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need |
Done. |
os-d
approved these changes
May 13, 2024
makubacki
approved these changes
May 14, 2024
The change will guard the CLANG-unsupported directives outside of the __clang__ macro define. This change does not have functional change other than minimal section literals. Signed-off-by: Kun Qin <[email protected]>
The existing library inf misses a few used libraries in its [LibraryClasses] section and thus break the build. This change adds those libraries and does not have functional change other than minimal section literals. Signed-off-by: Kun Qin <[email protected]>
kuqin12
force-pushed
the
personal/kuqin/clang_test
branch
from
151a887 to
27750ce
Compare
kuqin12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLANGPDB does not support directives such as
.typeand.size. This change removes them from the macro definitions when building with CLANGPDB.flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
This was tested on QEMU SBSA and booted to UEFI Shell.
Integration Instructions
N/A