Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the target list to support GIC v3 and above #226

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Apr 17, 2024

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

The edk2 change recently updated the CPU target list to be UINT8 only. However, when it comes to GIC v3 and above, we need to prepare the register value from the MPIDR value of the target core, which is a UINTN.

This change update the edk2 change to remain the expectation of GIC v3+ usage.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested on QEMU SBSA and proprietary physical platforms.

Integration Instructions

N/A

@kuqin12 kuqin12 requested review from cfernald, apop5 and os-d April 17, 2024 21:01
@kuqin12 kuqin12 merged commit 1819a69 into microsoft:release/202311 Apr 17, 2024
12 checks passed
@kuqin12 kuqin12 deleted the fix_sgi branch April 17, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants