Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REBASE & FF] Fix CodeQL Issues in AmlLib and PL061GPIO #202

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Jan 31, 2024

Description

Both of these components failed a CodeQL check for comparing non-equal width types in a loop. This fixes the issue.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Confirmed CI passed

Integration Instructions

N/A

@os-d os-d requested review from cfernald, kuqin12 and apop5 January 31, 2024 22:00
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jan 31, 2024
@os-d os-d merged commit a17dfd4 into microsoft:release/202311 Feb 1, 2024
12 checks passed
@os-d os-d deleted the osde/codeql branch February 1, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants