.sync/workflows/codeql: Use Version.njk cargo-make version #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
semver:patch
Most of the workflow can stay intact with GitHub caching working as-is but the cargo-make version now needs to match the version that is being synced to repos (i.e. matches rust-toolchain.toml). Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
use_sync_cargo_make_codeql_workflows
branch
from
a51a263 to
9fe0213
Compare
Javagedes
approved these changes
Feb 23, 2024
kuqin12
approved these changes
Feb 23, 2024
makubacki
added a commit
to makubacki/mu_devops
that referenced
this pull request
Feb 26, 2024
Changes since last release: microsoft/mu_devops@v9.1.5...v9.1.6 General release info: https://github.com/microsoft/mu_devops/releases --- Includes: - Sync RustSetupSteps.yml to use cargo-binstall to install cargo binary tools (microsoft#320) - Update RustSetupSteps.yml (microsoft#321) - Repo File Sync: synced file(s) with microsoft/mu_devops (microsoft#322) - .sync/workflows/codeql: Use Version.njk cargo-make version (microsoft#323) In particular, including microsoft#320 in this tag allows downstream repos to use the changes. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
added a commit
that referenced
this pull request
Feb 26, 2024
Changes since last release: v9.1.5...v9.1.6 General release info: https://github.com/microsoft/mu_devops/releases --- Includes: - Sync RustSetupSteps.yml to use cargo-binstall to install cargo binary tools (#320) - Update RustSetupSteps.yml (#321) - Repo File Sync: synced file(s) with microsoft/mu_devops (#322) - .sync/workflows/codeql: Use Version.njk cargo-make version (#323) In particular, including #320 in this tag allows downstream repos to use the changes. Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the workflow can stay intact with GitHub caching working
as-is but the cargo-make version now needs to match the version that
is being synced to repos (i.e. matches rust-toolchain.toml).
Note: We can consider using cargo binstall in the future but right now
only cargo-make is needed, and it is simple to directly cache that binary
as-is with existing code.